Re: [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy()

From: Kees Cook
Date: Mon Jul 17 2023 - 18:58:41 EST


On Mon, Jul 17, 2023 at 07:05:44PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 17, 2023 at 08:43:55AM -0700, Kees Cook wrote:
> > On Mon, Jul 17, 2023 at 12:33:32PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > I think this doesn't need to use seq_show_option_n() at all.
>
> Quite likely. Nevertheless, it's one of the dozens (?) warnings like this.
>
> ...
>
> > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Thank you for the review!
>
> I think it's you who may take it as seq_file.h seems everybody's playground.

Ah, good point. :P

--
Kees Cook