RE: [PATCH] pwm: Explicitly include correct DT includes

[nobuhiro1.iwamatsu]

Hi,

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Saturday, July 15, 2023 2:49 AM
> To: Thierry Reding <thierry.reding@xxxxxxxxx>; Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx>; Hector Martin <marcan@xxxxxxxxx>;
> Sven Peter <sven@xxxxxxxxxxxxx>; Alyssa Rosenzweig
> <alyssa@xxxxxxxxxxxxx>; Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>;
> Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>; Claudiu Beznea
> <claudiu.beznea@xxxxxxxxxxxxx>; Benson Leung <bleung@xxxxxxxxxxxx>;
> Guenter Roeck <groeck@xxxxxxxxxxxx>; Shawn Guo
> <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>;
> Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Fabio Estevam
> <festevam@xxxxxxxxx>; NXP Linux Team <linux-imx@xxxxxxx>; Paul
> Cercueil <paul@xxxxxxxxxxxxxxx>; Vladimir Zapolskiy <vz@xxxxxxxxx>; Neil
> Armstrong <neil.armstrong@xxxxxxxxxx>; Kevin Hilman
> <khilman@xxxxxxxxxxxx>; Jerome Brunet <jbrunet@xxxxxxxxxxxx>; Martin
> Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>; Conor Dooley
> <conor.dooley@xxxxxxxxxxxxx>; Daire McNamara
> <daire.mcnamara@xxxxxxxxxxxxx>; Matthias Brugger
> <matthias.bgg@xxxxxxxxx>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx>; Palmer Dabbelt
> <palmer@xxxxxxxxxxx>; Paul Walmsley <paul.walmsley@xxxxxxxxxx>;
> Michael Walle <michael@xxxxxxxx>; Orson Zhai <orsonzhai@xxxxxxxxx>;
> Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>; Chunyan Zhang
> <zhang.lyra@xxxxxxxxx>; Chen-Yu Tsai <wens@xxxxxxxx>; Jernej Skrabec
> <jernej.skrabec@xxxxxxxxx>; Samuel Holland <samuel@xxxxxxxxxxxx>;
> Hammer Hsieh <hammerh0314@xxxxxxxxx>; Jonathan Hunter
> <jonathanh@xxxxxxxxxx>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ
> ○ＯＳＴ) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-pwm@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; asahi@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; chrome-platform@xxxxxxxxxxxxxxx;
> linux-mips@xxxxxxxxxxxxxxx; linux-amlogic@xxxxxxxxxxxxxxxxxxx;
> linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx;
> linux-sunxi@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx
> Subject: [PATCH] pwm: Explicitly include correct DT includes
> 
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they "temporarily"
> include each other. They also include platform_device.h and of.h. As a result,
> there's a pretty much random mix of those include files used throughout the
> tree. In order to detangle these headers and replace the implicit includes with
> struct declarations, users need to explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

For drivers/pwm/pwm-visconti.c:
Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>

Best regards,
  Nobuhiro