Re: [PATCH v4 3/6] mmc: sdhci-cadence: SD6 controller support

[Krzysztof Kozlowski]

On 17/07/2023 14:51, Piyush Malgujar wrote:
> From: Dhananjay Kangude <dkangude@xxxxxxxxxxx>
> 
> Add support for SD6 controller for Marvell CN10k SoCs and related ops
> along with support for HS400 and HS400ES emmc modes.
> Updated HS200 tuning values and support to read tune configuration
> from FDT and support to configure and read host side drive strength,
> slew from device tree.
> 

...

>  static void sdhci_cdns_hs400_enhanced_strobe(struct mmc_host *mmc,
>  					     struct mmc_ios *ios)
>  {
> @@ -518,8 +1752,11 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
>  	struct sdhci_pltfm_host *pltfm_host;
>  	struct sdhci_cdns_priv *priv;
>  	struct clk *clk;
> +	bool sd6_ctrl;
>  	int ret;
>  	struct device *dev = &pdev->dev;
> +	sd6_ctrl = of_device_is_compatible(dev->of_node, "marvell,cdns-sd6hc");

Don't sprinkle compatibles in probe. You have match data for quirks and
flags.

> +
>  	static const u16 version = SDHCI_SPEC_400 << SDHCI_SPEC_VER_SHIFT;
>  

Best regards,
Krzysztof