Re: [PATCH] regmap-irq: Set IRQCHIP_MASK_ON_SUSPEND if no wake_base

From: Mark Brown
Date: Mon Jul 17 2023 - 15:22:52 EST


On Mon, Jul 17, 2023 at 12:16:54PM -0700, Samuel Holland wrote:

> If hardware provides no way to control which IRQs are wakeup enabled,
> then software needs to mask non-wakeup-enabled IRQs when going to sleep.

This isn't an unambigiously clear statement, especially for MFDs where
there might be a desire to have some function on the device be able to
wake the system (eg, headset button press on an audio CODEC or a RTC on
a PMIC) even if there's no control within the device...

> Fixes: 55ac85e942c6 ("regmap: irq: enable wake support by default")

...as the commit log does hint at. If there's a problem I think we need
some finer grained control here.

Attachment: signature.asc
Description: PGP signature