Re: [PATCH] mmc: Explicitly include correct DT includes

From: Rob Herring
Date: Mon Jul 17 2023 - 13:46:59 EST


On Fri, Jul 14, 2023 at 11:48 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> drivers/mmc/host/atmel-mci.c | 1 -
> drivers/mmc/host/cavium-octeon.c | 2 ++
> drivers/mmc/host/cavium-thunderx.c | 1 +
> drivers/mmc/host/davinci_mmc.c | 1 -
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> drivers/mmc/host/mtk-sd.c | 4 +---
> drivers/mmc/host/mxcmmc.c | 1 -
> drivers/mmc/host/mxs-mmc.c | 1 -
> drivers/mmc/host/owl-mmc.c | 3 ++-
> drivers/mmc/host/pxamci.c | 1 -
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 3 ++-
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
> drivers/mmc/host/sdhci-bcm-kona.c | 1 -
> drivers/mmc/host/sdhci-cadence.c | 2 +-
> drivers/mmc/host/sdhci-esdhc-imx.c | 2 +-
> drivers/mmc/host/sdhci-iproc.c | 2 +-
> drivers/mmc/host/sdhci-msm.c | 2 +-
> drivers/mmc/host/sdhci-of-arasan.c | 3 ++-

Not visible in the diff, but there's a double include of of.h. v2 coming.

> drivers/mmc/host/sdhci-of-at91.c | 2 +-
> drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
> drivers/mmc/host/sdhci-of-sparx5.c | 2 +-
> drivers/mmc/host/sdhci-omap.c | 1 -
> drivers/mmc/host/sdhci-pxav2.c | 1 -
> drivers/mmc/host/sdhci-s3c.c | 1 -
> drivers/mmc/host/sdhci-sprd.c | 1 -
> drivers/mmc/host/sdhci-tegra.c | 1 -
> drivers/mmc/host/sh_mmcif.c | 1 -
> drivers/mmc/host/uniphier-sd.c | 1 -
> drivers/mmc/host/wmt-sdmmc.c | 1 -
> 29 files changed, 20 insertions(+), 29 deletions(-)