Re: (subset) [PATCH v3 00/18] Add basic Minidump kernel driver support

From: Bjorn Andersson
Date: Mon Jul 17 2023 - 12:17:50 EST


On Sun, Jul 16, 2023 at 07:15:57PM -0600, Mathieu Poirier wrote:
> On Sat, Jul 15, 2023 at 03:13:34PM -0700, Bjorn Andersson wrote:
> >
> > On Wed, 03 May 2023 22:32:14 +0530, Mukesh Ojha wrote:
> > > Minidump is a best effort mechanism to collect useful and predefined data
> > > for first level of debugging on end user devices running on Qualcomm SoCs.
> > > It is built on the premise that System on Chip (SoC) or subsystem part of
> > > SoC crashes, due to a range of hardware and software bugs. Hence, the
> > > ability to collect accurate data is only a best-effort. The data collected
> > > could be invalid or corrupted, data collection itself could fail, and so on.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [01/18] remoteproc: qcom: Expand MD_* as MINIDUMP_*
> > commit: 318da1371246fdc1806011a27138175cfb078687
> >
>
> Krzysztof asked for modifications on this patch.
>

Krzysztof pointed out that there was no reason to trivially modify the
defines and then immediately start moving things around.

I agree with this, but as the consensus was that the rest of the series
needs more work, I find this to be a sensible cleanup, getting rid of
the cryptic "MD_" abbreviation.

Regards,
Bjorn