Re: [PATCH] mm: kill frontswap

From: Matthew Wilcox
Date: Mon Jul 17 2023 - 12:08:14 EST


On Mon, Jul 17, 2023 at 12:02:27PM -0400, Johannes Weiner wrote:
> - pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s%s\n",
> + pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s\n",
> p->pages<<(PAGE_SHIFT-10), name->name, p->prio,
> nr_extents, (unsigned long long)span<<(PAGE_SHIFT-10),
> (p->flags & SWP_SOLIDSTATE) ? "SS" : "",
> (p->flags & SWP_DISCARDABLE) ? "D" : "",
> (p->flags & SWP_AREA_DISCARD) ? "s" : "",
> - (p->flags & SWP_PAGE_DISCARD) ? "c" : "",
> - (frontswap_map) ? "FS" : "");
> + (p->flags & SWP_PAGE_DISCARD) ? "c" : "");

Is it useful information (to the sysadmin) that zswap is enabled? If so,
we might want to print a "Z" instead of a "FS" here (would need to
know whether enabling zswap succeeded ...)