Re: [PATCH v2 5/7] perf evlist: Skip dummy event sample_type check for evlist_config

[Adrian Hunter]

On 15/07/23 06:29, Yang Jihong wrote:
> The dummp event does not contain sampls data. Therefore, sample_type does
> not need to be checked.
> 
> Currently, the sample id format of the actual sampling event may be changed
> after the dummy event is added.
> 
> Signed-off-by: Yang Jihong <yangjihong1@xxxxxxxxxx>
> ---
>  tools/perf/util/record.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c
> index 9eb5c6a08999..0240be3b340f 100644
> --- a/tools/perf/util/record.c
> +++ b/tools/perf/util/record.c
> @@ -128,6 +128,13 @@ void evlist__config(struct evlist *evlist, struct record_opts *opts, struct call
>  		evlist__for_each_entry(evlist, evsel) {
>  			if (evsel->core.attr.sample_type == first->core.attr.sample_type)
>  				continue;
> +
> +			/*
> +			 * Skip the sample_type check for the dummy event
> +			 * because it does not have any samples anyway.
> +			 */
> +			if (evsel__is_dummy_event(evsel))
> +				continue;

Sideband event records have "ID samples" so the sample type still matters.


>  			use_sample_identifier = perf_can_sample_identifier();
>  			break;
>  		}