Re: [PATCH v2] KVM: arm64: Add missing BTI instructions

From: Mostafa Saleh
Date: Mon Jul 17 2023 - 05:48:52 EST


On Wed, Jul 12, 2023 at 10:50:34PM +0000, Oliver Upton wrote:
> On Thu, 6 Jul 2023 15:22:40 +0000, Mostafa Saleh wrote:
> > Some bti instructions were missing from
> > commit b53d4a272349 ("KVM: arm64: Use BTI for nvhe")
> >
> > 1) kvm_host_psci_cpu_entry
> > kvm_host_psci_cpu_entry is called from __kvm_hyp_init_cpu through "br"
> > instruction as __kvm_hyp_init_cpu resides in idmap section while
> > kvm_host_psci_cpu_entry is in hyp .text so the offset is larger than
> > 128MB range covered by "b".
> > Which means that this function should start with "bti j" instruction.
> >
> > [...]
>
> Applied to kvmarm/fixes. Sorry this took longer than expected, Mostafa. I
> was hitting an unrelated issue with pKVM initialization on the only system
> I have that supports BTI.
>
> [1/1] KVM: arm64: Add missing BTI instructions
> https://git.kernel.org/kvmarm/kvmarm/c/dcf89d111199
>

Thanks Oliver, hopefully everything is sorted out now.