Re: [PATCH v4 07/17] drm/imagination: Add GPU ID parsing and firmware loading

[Maxime Ripard]

On Fri, Jul 14, 2023 at 03:27:00PM +0100, Sarah Walker wrote:
> +/**
> + * pvr_device_gpu_fini() - GPU-specific deinitialization for a PowerVR device
> + * @pvr_dev: Target PowerVR device.
> + */
> +static void
> +pvr_device_gpu_fini(struct pvr_device *pvr_dev)
> +{
> +	release_firmware(pvr_dev->fw_dev.firmware);
> +}
> +

Since you call that function at remove time, I think you can register a
devm action using devm_add_action_or_reset() to remove the need to call
it explicitly (and probably the need to have pvr_device_fini() in the
first place)

Maxime

Attachment: signature.asc
Description: PGP signature