Re: [PATCH] dt-bindings: spi: convert spi-brcm63xx.txt to YAML

From: Krzysztof Kozlowski
Date: Mon Jul 17 2023 - 03:32:23 EST


On 15/07/2023 12:02, Jonas Gorski wrote:
> Changes done during conversion:
>
> * added a description, lifting and adapting the limitation sentence from
> brcm,bcm63xx-hsspi.yml
> * added appropriate compatibles for

...

> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm6368-spi
> + - brcm,bcm6362-spi
> + - brcm,bcm63268-spi
> + - const: brcm,bcm6358-spi
> + - const: brcm,bcm6348-spi
> + - const: brcm,bcm6358-spi

These two are just enum. It's preferred syntax.

> +
> + reg:
> + items:
> + - description: main registers

Instead shorter:
maxItems: 1

With above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof