Re: [PATCH] proc: Fix four errors in kmsg.c

From: Sergey Senozhatsky
Date: Mon Jul 17 2023 - 02:05:11 EST


On (23/07/14 10:22), Petr Mladek wrote:
> On Fri 2023-07-14 14:57:59, huzhi001@xxxxxxxxxx wrote:
> > The following checkpatch errors are removed:
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
>
> Please, do not do fix these cosmetic issues reported by checkpatch.pl.
> It is not worth the effort. In fact, it is contra productive.
> It complicates the git history, backports.

Absolutely agree with Petr.

As a side note, I wonder if checkpatch can deprecate that -f option?