[PATCH] cxl: Fix memory leak bug in alloc_mock_res()

From: Chenyuan Mi
Date: Sun Jul 16 2023 - 23:55:45 EST


When gen_pool_alloc_algo() fails, the error handling path
forgets to free 'res'. It would cause a memory leak bug.

Fix it by add kfree() in error handling path.

Signed-off-by: Chenyuan Mi <michenyuan@xxxxxxxxxx>
---
tools/testing/cxl/test/cxl.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
index 0e78d8e19895..250ffd147067 100644
--- a/tools/testing/cxl/test/cxl.c
+++ b/tools/testing/cxl/test/cxl.c
@@ -405,8 +405,10 @@ static struct cxl_mock_res *alloc_mock_res(resource_size_t size, int align)
INIT_LIST_HEAD(&res->list);
phys = gen_pool_alloc_algo(cxl_mock_pool, size,
gen_pool_first_fit_align, &data);
- if (!phys)
+ if (!phys) {
+ kfree(res);
return NULL;
+ }

res->range = (struct range) {
.start = phys,
--
2.25.1