arch/riscv/kernel/signal.c:94:16: sparse: sparse: incorrect type in initializer (different address spaces)

From: kernel test robot
Date: Sun Jul 16 2023 - 22:20:57 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5b8d6e8539498e8b2fa67fbcce3fe87834d44a7a
commit: fa8e7cce55da3569259dc270801885c420eb50fe riscv: Enable Vector code to be built
date: 6 weeks ago
config: riscv-randconfig-r071-20230717 (https://download.01.org/0day-ci/archive/20230717/202307171012.U1gkffCQ-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230717/202307171012.U1gkffCQ-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307171012.U1gkffCQ-lkp@xxxxxxxxx/

sparse warnings: (new ones prefixed by >>)
WARNING: invalid argument to '-march': '_zihintpause'
>> arch/riscv/kernel/signal.c:94:16: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *__val @@ got void [noderef] __user *[assigned] datap @@
arch/riscv/kernel/signal.c:94:16: sparse: expected void *__val
arch/riscv/kernel/signal.c:94:16: sparse: got void [noderef] __user *[assigned] datap

vim +94 arch/riscv/kernel/signal.c

8ee0b41898fa26 Greentime Hu 2023-06-05 72
8ee0b41898fa26 Greentime Hu 2023-06-05 73 static long save_v_state(struct pt_regs *regs, void __user **sc_vec)
8ee0b41898fa26 Greentime Hu 2023-06-05 74 {
8ee0b41898fa26 Greentime Hu 2023-06-05 75 struct __riscv_ctx_hdr __user *hdr;
8ee0b41898fa26 Greentime Hu 2023-06-05 76 struct __sc_riscv_v_state __user *state;
8ee0b41898fa26 Greentime Hu 2023-06-05 77 void __user *datap;
8ee0b41898fa26 Greentime Hu 2023-06-05 78 long err;
8ee0b41898fa26 Greentime Hu 2023-06-05 79
8ee0b41898fa26 Greentime Hu 2023-06-05 80 hdr = *sc_vec;
8ee0b41898fa26 Greentime Hu 2023-06-05 81 /* Place state to the user's signal context space after the hdr */
8ee0b41898fa26 Greentime Hu 2023-06-05 82 state = (struct __sc_riscv_v_state __user *)(hdr + 1);
8ee0b41898fa26 Greentime Hu 2023-06-05 83 /* Point datap right after the end of __sc_riscv_v_state */
8ee0b41898fa26 Greentime Hu 2023-06-05 84 datap = state + 1;
8ee0b41898fa26 Greentime Hu 2023-06-05 85
8ee0b41898fa26 Greentime Hu 2023-06-05 86 /* datap is designed to be 16 byte aligned for better performance */
8ee0b41898fa26 Greentime Hu 2023-06-05 87 WARN_ON(unlikely(!IS_ALIGNED((unsigned long)datap, 16)));
8ee0b41898fa26 Greentime Hu 2023-06-05 88
8ee0b41898fa26 Greentime Hu 2023-06-05 89 riscv_v_vstate_save(current, regs);
8ee0b41898fa26 Greentime Hu 2023-06-05 90 /* Copy everything of vstate but datap. */
8ee0b41898fa26 Greentime Hu 2023-06-05 91 err = __copy_to_user(&state->v_state, &current->thread.vstate,
8ee0b41898fa26 Greentime Hu 2023-06-05 92 offsetof(struct __riscv_v_ext_state, datap));
8ee0b41898fa26 Greentime Hu 2023-06-05 93 /* Copy the pointer datap itself. */
8ee0b41898fa26 Greentime Hu 2023-06-05 @94 err |= __put_user(datap, &state->v_state.datap);
8ee0b41898fa26 Greentime Hu 2023-06-05 95 /* Copy the whole vector content to user space datap. */
8ee0b41898fa26 Greentime Hu 2023-06-05 96 err |= __copy_to_user(datap, current->thread.vstate.datap, riscv_v_vsize);
8ee0b41898fa26 Greentime Hu 2023-06-05 97 /* Copy magic to the user space after saving all vector conetext */
8ee0b41898fa26 Greentime Hu 2023-06-05 98 err |= __put_user(RISCV_V_MAGIC, &hdr->magic);
8ee0b41898fa26 Greentime Hu 2023-06-05 99 err |= __put_user(riscv_v_sc_size, &hdr->size);
8ee0b41898fa26 Greentime Hu 2023-06-05 100 if (unlikely(err))
8ee0b41898fa26 Greentime Hu 2023-06-05 101 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 102
8ee0b41898fa26 Greentime Hu 2023-06-05 103 /* Only progress the sv_vec if everything has done successfully */
8ee0b41898fa26 Greentime Hu 2023-06-05 104 *sc_vec += riscv_v_sc_size;
8ee0b41898fa26 Greentime Hu 2023-06-05 105 return 0;
8ee0b41898fa26 Greentime Hu 2023-06-05 106 }
8ee0b41898fa26 Greentime Hu 2023-06-05 107

:::::: The code at line 94 was first introduced by commit
:::::: 8ee0b41898fa26f66e32237f179b6989c65600d6 riscv: signal: Add sigcontext save/restore for vector

:::::: TO: Greentime Hu <greentime.hu@xxxxxxxxxx>
:::::: CC: Palmer Dabbelt <palmer@xxxxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki