RE: [PATCH] crypto: starfive - Add AES skcipher and aead support

From: JiaJie Ho
Date: Sun Jul 16 2023 - 22:06:35 EST


> This doesn't compile:
>
> CC [M] drivers/crypto/starfive/jh7110-cryp.o
> CC [M] drivers/crypto/starfive/jh7110-hash.o
> CC [M] drivers/crypto/starfive/jh7110-rsa.o
> CC [M] drivers/crypto/starfive/jh7110-aes.o
> In file included from ../drivers/crypto/starfive/jh7110-aes.c:13:
> ../drivers/crypto/starfive/jh7110-cryp.h:184:49: error: field ‘aes_done’ has
> incomplete type
> 184 | struct tasklet_struct aes_done;
> | ^~~~~~~~
> ../drivers/crypto/starfive/jh7110-cryp.h:185:49: error: field ‘hash_done’ has
> incomplete type
> 185 | struct tasklet_struct hash_done;
> | ^~~~~~~~~
> make[6]: *** [../scripts/Makefile.build:243: drivers/crypto/starfive/jh7110-
> aes.o] Error 1
> make[6]: *** Waiting for unfinished jobs....
>

Hi Herbert,
Thanks for reviewing the patch.
I found out that it's missing interrupt.h include.
It is weird that the compile error did not show in the original driver and on my local build.
I'll fix this in the next version.

Thanks,
Jia Jie