RE: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()

[Ping-Ke Shih]

> -----Original Message-----
> From: Zhang Shurong <zhang_shurong@xxxxxxxxxxx>
> Sent: Saturday, July 15, 2023 9:43 PM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Markus.Elfring@xxxxxx; kuba@xxxxxxxxxx
> Cc: kvalo@xxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Zhang Shurong
> <zhang_shurong@xxxxxxxxxxx>
> Subject: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()
> 
> If there is a failure during kstrtobool_from_user()
> rtw89_debug_priv_btc_manual_set should return a negative error code
> instead of returning the count directly.
> 
> Fix this bug by returning an error code instead of a count after
> a failed call of the function "kstrtobool_from_user". Moreover
> I omitted the label "out" with this source code correction.
> 
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Zhang Shurong <zhang_shurong@xxxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

> ---
> Changes in v2:
> - Corrected the format of this patch
> - Used variable ret instead of goto out
> Changes in v3:
> - Improved change description
> Changes in v4:
> - Improved change description
> 

Normally, we preserve three '-' as delimiter here. I tried to use pwclient to 
apply this patch, and fortunately it works. So, I think no need to resend because
of this.

[...]