[PATCH v2 0/2] add mcp4728 I2C DAC driver​

[Andrea Collamati]

Dear Krzysztof

I release a V2 version. I hope I have understood all your requests.
See below.

> 2. Please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC (and consider --no-git-fallback argument). It
> might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on
> recent Linux kernel.
>
I was using branch master git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git but

I saw it was too old. I switched to branch testing.
> 6. mcp or MCP? What is this? Proper title is missing... also no
> description.
>
I don't know whether using small o capital letters. Usually manufacturers use capital letter to identify the component
but kernel drivers use lowercase in code.
>
> Shouldn't this binding be just merged with existing mcp4725? Are you
> sure it's not similar device, IOW, are you sure you do not have vref supply?
>
Unfortunately they are not that similar. MCP4728 has two vref choices:

- Use Vdd (power supply) as Vref

- User Internal 2.048 V Vref source.


Andrea Collamati (2):
  dt-bindings: iio: dac: add mcp4728.yaml
  iio: add mcp4728 I2C DAC driver

 .../bindings/iio/dac/microchip,mcp4728.yaml   | 42 +++++++++
 drivers/iio/dac/mcp4728.c                     | 93 +++++++++----------
 2 files changed, 86 insertions(+), 49 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml

-- 
2.34.1