Re: [PATCH v3] HID: hid-google-stadiaff: add support for Stadia force feedback

[Rahul Rameshbabu]

On Sun, 16 Jul, 2023 18:39:24 +0000 Fabio Baltieri <fabiobaltieri@xxxxxxxxxxxx> wrote:
> Hi Rahul,
>
> On Fri, Jul 14, 2023 at 02:13:34PM -0700, Rahul Rameshbabu wrote:
>> On Sun, 09 Jul, 2023 21:44:10 +0000 Fabio Baltieri <fabiobaltieri@xxxxxxxxxxxx> wrote:
>> > Add a hid-stadiaff module to support rumble based force feedback on the
>> > Google Stadia controller. This works using the HID output endpoint
>> > exposed on both the USB and BLE interface.
>> >
>> > Signed-off-by: Fabio Baltieri <fabiobaltieri@xxxxxxxxxxxx>
>> > ---
>> > +static int stadia_probe(struct hid_device *hdev, const struct hid_device_id *id)
>> > +{
>> > +	int ret;
>> > +
>> > +	ret = hid_parse(hdev);
>> > +	if (ret) {
>> > +		hid_err(hdev, "parse failed\n");
>> > +		return ret;
>> > +	}
>> > +
>> > +	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF);
>> > +	if (ret) {
>> > +		hid_err(hdev, "hw start failed\n");
>> > +		return ret;
>> > +	}
>> > +
>> > +	ret = stadiaff_init(hdev);
>> > +	if (ret) {
>> > +		dev_err(&hdev->dev, "force feedback init failed\n");
>> 
>> Error handling looks good to me now. Is there any particular reason you
>> use dev_err here instead of hid_err here?
>
> Not really, copied from another hid driver and did not realize the
> inconsistency. I'll fix that up and send a v4.
>
> Thanks again for spotting this!

No worries. Btw, in your commit message body, you might want to change
hid-stadiaff to hid-google-stadiaff as well for your v4 submission.

Thanks,

-- Rahul Rameshbabu