Re: [PATCH v2 5/6] net: phy: at803x: remove qca8081 1G fast retrain and slave seed config

[Jie Luo]

On 7/14/2023 7:41 PM, Russell King (Oracle) wrote:
> On Fri, Jul 14, 2023 at 02:31:35PM +0800, Luo Jie wrote:
> > The fast retrain and master slave seed configs are only applicable when
> > the 2.5G capability is supported.
>
> Probably worth a comment - or a helper function.
>
> E.g.
>
> static bool qca808x_has_fast_retrain(struct phy_device *phydev)
> {
> 	return linkmode_test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
> 				 phydev->supported);
> }
>
> Which then makes the code more self-documenting.

Hi Russell,
Thanks for this review comment, i will add this helper function in the 
next patch series.