RE: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

From: SHANMUGAM, SRINIVASAN
Date: Sat Jul 15 2023 - 01:10:39 EST


[Public]

Reviewed-by: Srinivasan Shanmugam <srinivasan.shanmugam@xxxxxxx>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of shijie001@xxxxxxxxxx
Sent: Friday, July 14, 2023 1:36 PM
To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; airlied@xxxxxxxxx; daniel@xxxxxxxx
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

Fix five occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
ERROR: that open brace { should be on the previous line

Signed-off-by: Jie Shi <shijie001@xxxxxxxxxx>
---
drivers/gpu/drm/radeon/radeon_audio.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_audio.c
b/drivers/gpu/drm/radeon/radeon_audio.c
index d6ccaf24ee0c..a010bc2c155c 100644
--- a/drivers/gpu/drm/radeon/radeon_audio.c
+++ b/drivers/gpu/drm/radeon/radeon_audio.c
@@ -35,15 +35,14 @@

void dce6_audio_enable(struct radeon_device *rdev, struct r600_audio_pin *pin,
u8 enable_mask);
-struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev); -struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *r600_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev);
static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder,
struct drm_display_mode *mode);
static void radeon_audio_dp_mode_set(struct drm_encoder *encoder,
struct drm_display_mode *mode);

-static const u32 pin_offsets[7] =
-{
+static const u32 pin_offsets[7] = {
(0x5e00 - 0x5e00),
(0x5e18 - 0x5e00),
(0x5e30 - 0x5e00),
@@ -359,7 +358,7 @@ static void radeon_audio_write_latency_fields(struct
drm_encoder *encoder,
radeon_encoder->audio->write_latency_fields(encoder, connector, mode);
}

-struct r600_audio_pin* radeon_audio_get_pin(struct drm_encoder
*encoder)
+struct r600_audio_pin *radeon_audio_get_pin(struct drm_encoder
*encoder)
{
struct radeon_device *rdev = encoder->dev->dev_private;
struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder); @@ -526,7 +525,7 @@ static void radeon_audio_calc_cts(unsigned int clock, int *CTS, int *N, int freq
*N, *CTS, freq);
}

-static const struct radeon_hdmi_acr* radeon_audio_acr(unsigned int
clock)
+static const struct radeon_hdmi_acr *radeon_audio_acr(unsigned int
clock)
{
static struct radeon_hdmi_acr res;
u8 i;