Re: [PATCH v3] mtd: spi-nor: Correct flags for Winbond w25q128

[Linus Walleij]

On Fri, Jul 14, 2023 at 9:30 PM Michael Walle <michael@xxxxxxxx> wrote:
> Am 2023-07-14 20:29, schrieb Linus Walleij:

> > The Winbond "w25q128" (actual vendor name W25Q128JV) has
> > exactly the same flags as the sibling device "w25q128jv".
> > The devices both require unlocking to enable write access.
> >
> > The actual product naming between devices vs the Linux
> > strings in winbond.c:
> >
> > 0xef4018: "w25q128"   W25Q128JV-IM/JM
> > 0xef7018: "w25q128jv" W25Q128JV-IN/IQ/JQ
>
> This is still wrong btw. According to:
> https://www.winbond.com/resource-files/W25Q128JV%20RevI%2008232021%20Plus.pdf
>
> This should be
> 0xef4018: "w25q128"   W25Q128JV-IN/IQ/JQ
> 0xef7018: "w25q128jv" W25Q128JV-IM/JM
>
> Otherwise, looks good. Either Tudor can change that in
> place while picking up the patch or you could send a new
> version.

Ooops you're right, I'll just pick up your tag and re-send,
sorry!

Yours,
Linus Walleij