Re: [PATCH v3] Documentation/highmem: Add information about kmap_local_folio()

From: Jonathan Corbet
Date: Fri Jul 14 2023 - 15:45:14 EST


"Fabio M. De Francesco" <fmdefrancesco@xxxxxxxxx> writes:

> The differences between kmap_local_page() and kmap_local_folio() consist
> only in the first taking a pointer to a page and the second taking two
> arguments, a pointer to a folio and the byte offset within the folio which
> identifies the page.
>
> The two API's can be explained at the same time in the "Temporary Virtual
> Mappings" section of the Highmem's documentation.
>
> Add information about kmap_local_folio() in the same subsection that
> explains kmap_local_page().
>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Ira Weiny <ira.weiny@xxxxxxxxx>
> Cc: Jonathan Corbet <corbet@xxxxxxx>
> Cc: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Cc: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> Cc: Peter Collingbourne <pcc@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Vlastimil Babka <vbabka@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> Reviewed-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> ---
>
> v2->v3: Replaced "request" with "create". Noticed by Randy (thanks),
> fixed by Matthew (again thanks).
> https://lore.kernel.org/lkml/970a881a-cdaf-2568-657a-3b93b0273338@xxxxxxxxxxxxx/
>
> v1-v2: I had Cc'ed everybody but Andrew :-( Sorry, it's now fixed.
> In the meantime, I collected the review tags by Ira and Mike
> (thanks to both of you). All entries are listed using a simple
> ascending lexycographycal order based on first names.
>
> Documentation/mm/highmem.rst | 27 +++++++++++++++------------
> 1 file changed, 15 insertions(+), 12 deletions(-)

Applied, thanks.

jon