Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg

From: Andrew Lunn
Date: Fri Jul 14 2023 - 14:54:30 EST


> + motorcomm,rx-clk-driver-strength:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + drive strength of rx_clk rgmii pad.
> + |----------------------------------|
> + | rx_clk ds map table |
> + |----------------------------------|
> + | DS(3b) | wol@1.8v | wol@3.3v |
> + |________|_________________________|
> + | | current(uA)| current(uA)|
> + | 000 | 1200 | 3070 |
> + | 001 | 2100 | 4080 |
> + | 010 | 2700 | 4370 |
> + | 011 | 2910 | 4680 |
> + | 100 | 3110 | 5020 |
> + | 101 | 3600 | 5450 |
> + | 110 | 3970 | 5740 |
> + | 111 | 4350 | 6140 |
> + |--------|------------|------------|
> + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
> + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
> + default: 2910

The DS(3b) value is not relevant to the binding. It is a driver
detail. So i would not bother listing it.

Please add a comment explaining what wol is.

Andrew