Re: [PATCH] rust: kernel: str: Implement Debug for CString

From: Alice Ryhl
Date: Fri Jul 14 2023 - 10:02:08 EST


Asahi Lina <lina@xxxxxxxxxxxxx> writes:
> On 14/07/2023 18.48, Alice Ryhl wrote:
>> Asahi Lina <lina@xxxxxxxxxxxxx> writes:
>>> Trivial implementation.
>>>
>>> Signed-off-by: Asahi Lina <lina@xxxxxxxxxxxxx>
>>
>> The commit message is a bit short, but the change itself looks fine.
>>
>> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>
> It's so trivial I just didn't know what else to write... suggestions
> welcome (for this or next time I have a patch like this) ^^
>
> ~ Lina

Adding some sort of motivation usually works quite well, e.g.:

Make it possible to use a CString with the `pr_*` macros directly, that
is, instead of

pr_debug!("trying to open {:?}\n", &*filename);

we can now write

pr_debug!("trying to open {:?}\n", filename);

Alice