Re: Fwd: [PATCH] tty:Insert clk_put before return (clk) to release memory

From: Ilpo Järvinen
Date: Fri Jul 14 2023 - 07:49:03 EST


On Fri, 14 Jul 2023, liubin001@xxxxxxxxxx wrote:

>
> tty/serial:Insert clk_put before return (clk) to release memory
> Signed-off-by: Liu Bin <liubin001@xxxxxxxxx>
> ---
> drivers/tty/serial/bcm63xx_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/bcm63xx_uart.c
> b/drivers/tty/serial/bcm63xx_uart.c
> index 55e82d0bf92d..7353b683952d 100644
> --- a/drivers/tty/serial/bcm63xx_uart.c
> +++ b/drivers/tty/serial/bcm63xx_uart.c
> @@ -851,6 +851,7 @@ static int bcm_uart_probe(struct platform_device *pdev)
> clk = of_clk_get(pdev->dev.of_node, 0);
>
> if (IS_ERR(clk))
> + clk_put(clk);
> return -ENODEV;

Braces missing... Didn't checkpatch complain about this?

--
i.