Re: [PATCH v2 1/6] net: phy: at803x: support qca8081 genphy_c45_pma_read_abilities

From: Russell King (Oracle)
Date: Fri Jul 14 2023 - 06:44:53 EST


On Fri, Jul 14, 2023 at 02:31:31PM +0800, Luo Jie wrote:
> qca8081 PHY supports to use genphy_c45_pma_read_abilities for
> getting the PHY features supported except for the autoneg ability
>
> but autoneg ability exists in MII_BMSR instead of MMD7.1, add it

When talking about clause 45 PHYs, they don't have a BMSR. The
correct definition is MDIO_STAT1, or "status 1 register".

Apart from that,

Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!