Re: [PATCH/RFC 3/8] drm/ssd130x: Bail out early if data_array is not yet available

From: Javier Martinez Canillas
Date: Fri Jul 14 2023 - 05:53:56 EST


Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:

> Calling ssd130x_buf_alloc() from ssd130x_encoder_helper_atomic_enable()
> is too late, causing a NULL pointer dereference:
>
> ssd130x_update_rect.isra.0+0x13c/0x340
> ssd130x_primary_plane_helper_atomic_update+0x26c/0x284
> drm_atomic_helper_commit_planes+0xfc/0x27c
>
> Work around that by checking if data_array is valid.
>
> Obviously this needs a better fix...
>

This should be fixed by [0] so we can drop this patch from the set.

[0]: https://lists.freedesktop.org/archives/dri-devel/2023-July/413630.html

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat