Re: [PATCH] proc: Fix four errors in kmsg.c

From: Petr Mladek
Date: Fri Jul 14 2023 - 04:31:45 EST


On Fri 2023-07-14 10:22:48, Petr Mladek wrote:
> On Fri 2023-07-14 14:57:59, huzhi001@xxxxxxxxxx wrote:
> > The following checkpatch errors are removed:
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
>
> Please, do not do fix these cosmetic issues reported by checkpatch.pl.
> It is not worth the effort. In fact, it is contra productive.
> It complicates the git history, backports.

BTW, Did anyone suggest you to fix errors/warnings reported by
checkpatch.pl?

You seem to be 2nd person who sent similar patch from @suo.com
within the last week. The first patch was rejected as well,
see
https://lore.kernel.org/all/f2d8eb955890bc1db1b307db713d4a4a@xxxxxxxxxx/

You might want to tell this person that there are better ways
how to get involved into the kernel development.

Best Regards,
Petr