Re: [PATCH v4 10/19] selftests/resctrl: Express span internally in bytes

[Wieczor-Retman, Maciej]

Hi Reinette!

On 14.07.2023 01:00, Reinette Chatre wrote:
> Hi Ilpo,
> 
> On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
>> MBA and MBM tests to use megabytes to represent span. CMT test uses
>> bytes. The difference requires run_benchmark() to size the buffer
>> differently based on the test name, which in turn requires passing the
>> test name into run_benchmark().
>>
>> Convert MBA and MBM tests to use internally bytes like CMT test to
>> remove the internal inconsistency between the tests. Remove the test
>> dependent buffer sizing from run_benchmark().
> 
> If I understand correctly the intention is to always use bytes internally
> and only convert to megabytes when displayed to user space. The above
> implies that this takes care of the conversion but there still seems
> to be places that that do not follow my understanding. For example,
> resctrl_val.c:measure_vals() converts to megabytes before proceeding.

Doesn't the use case inside resctrl_val.c:measure_vals() satisfy
the idea of only displaying data to the user space? From my
understanding it reads the number of bytes and only converts to
MB when printing the value. Or did I miss some detail there?

> 
> While MBA, MBM, and CMT tests use resctrl_val() for testing it seems
> as though the function still exits with the MBA/MBM data recorded in
> megabytes with the CMT data recorded in bytes. That seems to be why
> show_mba_info() needs no conversion when displaying the data.
> 
> Reinette

Kind regards
Maciej Wieczór-Retman

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.