Re: [PATCH] erofs: deprecate superblock checksum feature

From: Gao Xiang
Date: Fri Jul 14 2023 - 01:58:34 EST




On 2023/7/14 12:50, Jingbo Xu wrote:


On 7/14/23 12:29 PM, Gao Xiang wrote:


On 2023/7/14 11:38, Jingbo Xu wrote:
Later we're going to introduce fs-verity based verification for the
whole image.  Make the superblock checksum feature deprecated.

I'd suggest that


"Later we're going to try the self-contained image verification.
 The current superblock checksum feature has quite limited
 functionality, instead, merkle trees can provide better protection
 for image integrity.

 Since the superblock checksum is a compatible feature, just
 deprecate now. "

Yeah, another concern is that xxhash is used in the following xattr name
filter feature [1] which is on the way. It may be redundant to use two
hashing algorithms for one filesystem.

Please help add this to the commit message when the next version
is sent.

Thanks,
Gao Xiang