Re: [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property

From: Bjorn Andersson
Date: Thu Jul 13 2023 - 23:16:53 EST


On Thu, Jul 13, 2023 at 08:37:55AM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2023 01:59, David Heidelberg wrote:
> > The driver has support for it already. Only missing bit is dt-binding entry.
>
> No, because the child node already has it. We do not need to extcons for
> one USB. Also another reason is that it should be deprecated.
>

In the current design of the Linux dwc3 driver we actually need both
nodes to be extcon targets, as both device drivers needs to react to the
role change. So I think the patch accurately describes the intended
design of today.

That said, we do not want to do this for the Type-C case, where we use a
full port node. Combined with other reasons, we really should fix the
dwc3 driver model so that the core propagates the role changes to the
glue drivers, and as such I agree that we shouldn't pick this patch.

Regards,
Bjorn