RE: [PATCH net v1] net: ethernet: Remove repeating expression

From: Jiawen Wu
Date: Thu Jul 13 2023 - 21:49:03 EST


On Thursday, July 13, 2023 8:16 PM, Wang Ming wrote:
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch. Need to remove duplicate expression in if statement.
>
> Signed-off-by: Wang Ming <machel@xxxxxxxx>
> ---
> drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> index 39a9aeee7aab..6321178fc814 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> @@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx)
> psrtype = WX_RDB_PL_CFG_L4HDR |
> WX_RDB_PL_CFG_L3HDR |
> WX_RDB_PL_CFG_L2HDR |
> - WX_RDB_PL_CFG_TUN_TUNHDR |
> WX_RDB_PL_CFG_TUN_TUNHDR;
> wr32(wx, WX_RDB_PL_CFG(0), psrtype);

Reviewed-by: Jiawen Wu <jiawenwu@xxxxxxxxxxxxxx>