Re: [PATCH v2] Revert "usb: dwc3: core: Enable AutoRetry feature in the controller"

[Thinh Nguyen]

On Thu, Jul 13, 2023, Jakub Vaněk wrote:
> Hi Thinh,
> 
> On Wed, 2023-07-12 at 22:55 +0000, Thinh Nguyen wrote:
> > On Thu, Jul 13, 2023, Jakub Vanek wrote:
> > > This reverts commit b138e23d3dff90c0494925b4c1874227b81bddf7.
> > > 
> > > AutoRetry has been found to cause some issues. This feature allows
> > > the controller in host mode (further referred to as the xHC) to
> > > send
> > > non-terminating/burst retry ACKs (Retry=1 and Nump!=0) instead of
> > > terminating retry ACKs (Retry=1 and Nump=0) to devices when
> > > a transaction error occurs.
> > > 
> > > Unfortunately, some USB devices fail to retry transactions when
> > > the xHC sends them a burst retry ACK. When this happens, the xHC
> > 
> > For some clarity: if the device continues to respond with CRC error,
> > the xHC will not complete endpoint related commands while it keeps
> > autoretry.
> 
> Acknowledged. Do you think it it would be better to respin this patch
> once more to include this in the changelog?
> 

It'll be better to provide more detail. However, I'm fine whether you
want to send v3 with this or not.

Thanks,
Thinh