Re: [PATCH v2 net] gso: fix dodgy bit handling for GSO_UDP_L4
From: Willem de Bruijn
Date: Thu Jul 13 2023 - 13:38:59 EST
On Thu, Jul 13, 2023 at 1:28 PM Yan Zhai <yan@xxxxxxxxxxxxxx> wrote:
>
> Commit 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4
> packets.") checks DODGY bit for UDP, but for packets that can be fed
> directly to the device after gso_segs reset, it actually falls through
> to fragmentation:
>
> https://lore.kernel.org/all/CAJPywTKDdjtwkLVUW6LRA2FU912qcDmQOQGt2WaDo28KzYDg+A@xxxxxxxxxxxxxx/
>
> This change restores the expected behavior of GSO_UDP_L4 packets.
>
> Fixes: 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4 packets.")
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>
> Signed-off-by: Yan Zhai <yan@xxxxxxxxxxxxxx>
Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx>
for next time: places hyperlinks in the block of tags at the bottom of
the commit as "Link: ${URL}"