Re: [PATCH v2 4/5] drm/ssd130x: Don't allocate buffers on each plane update

From: Javier Martinez Canillas
Date: Thu Jul 13 2023 - 12:36:17 EST


Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:

Hello Geert,

> Hi Javier,

[...]

>> +static const struct drm_mode_config_helper_funcs ssd130x_mode_config_helpers = {
>> + .atomic_commit_tail = drm_atomic_helper_commit_tail_rpm,
>> +};
>> +
>> static const uint32_t ssd130x_formats[] = {
>> DRM_FORMAT_XRGB8888,
>> };
>> @@ -923,6 +927,7 @@ static int ssd130x_init_modeset(struct ssd130x_device *ssd130x)
>> drm->mode_config.max_height = max_height;
>> drm->mode_config.preferred_depth = 24;
>> drm->mode_config.funcs = &ssd130x_mode_config_funcs;
>> + drm->mode_config.helper_private = &ssd130x_mode_config_helpers;
>>
>> /* Primary plane */
>>
>
> Thanks, that works!
>

Thanks for testing! Proper patch sent:

https://lists.freedesktop.org/archives/dri-devel/2023-July/413630.html

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat