Re: [PATCH] ext4: fix off by one issue in ext4_mb_choose_next_group_best_avail()

From: Theodore Ts'o
Date: Thu Jul 13 2023 - 10:55:40 EST



On Fri, 09 Jun 2023 16:04:03 +0530, Ojaswin Mujoo wrote:
> In ext4_mb_choose_next_group_best_avail(), we want the start order to be
> 1 less than goal length and the min_order to be, at max, 1 more than the
> original length. This commit fixes an off by one issue that arose due to
> the fact that 1 << fls(n) > (n).
>
> After all the processing:
>
> [...]

Applied, thanks!

[1/1] ext4: fix off by one issue in ext4_mb_choose_next_group_best_avail()
commit: 7c79210b15ef69a5702d1fb817bad9a30bffb097

Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>