RE: [PATCH net-next] tools: ynl-gen: fix parse multi-attr enum attribute

From: Kubalewski, Arkadiusz
Date: Thu Jul 13 2023 - 05:23:10 EST


>From: Jakub Kicinski <kuba@xxxxxxxxxx>
>Sent: Wednesday, July 12, 2023 6:24 PM
>To: Kubalewski, Arkadiusz <arkadiusz.kubalewski@xxxxxxxxx>
>Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>davem@xxxxxxxxxxxxx; pabeni@xxxxxxxxxx; edumazet@xxxxxxxxxx;
>chuck.lever@xxxxxxxxxx
>Subject: Re: [PATCH net-next] tools: ynl-gen: fix parse multi-attr enum
>attribute
>
>On Wed, 12 Jul 2023 09:47:43 +0000 Kubalewski, Arkadiusz wrote:
>> >+ if 'enum' in attr_spec:
>> >+ decoded = self._decode_enum(rsp, attr_spec)
>
>To be clear - this is just a quick mock up, you'll need to change
>the arguments here, obviously. Probably to decoded and attr_spec?

Well I did something that works for me:
("[PATCH net-next 0/2] tools: ynl-gen: fix parse multi-attr enum attribute")

But I am pretty sure it could break the other _decode_enum call
(from _decode_binary(..)), wasn't able to test it yet, as it seems to be used
only with ovs_flow.yaml spec (binary + struct type attr).

If you could take a look would be great.

Thank you!
Arkadiusz