Re: [PATCH V1 0/3] Add notifier call chain to Embedded USB Debug(EUD) driver

From: Souradeep Chowdhury
Date: Thu Jul 13 2023 - 04:35:05 EST




On 7/12/2023 10:10 PM, Greg KH wrote:
On Wed, Jul 12, 2023 at 01:52:37PM +0530, Souradeep Chowdhury wrote:
This patch series adds the notifier chain to the Embedded USB Debug(EUD) driver.
The notifier chain is used to check the role switch status of EUD. Since EUD can
function only in device mode, other modules trying to do role-switch on the same
port have to first check the EUD status by calling this notifier chain and based
on the status proceed or block their role-switching step. The modules can call
the notifier through the call eud_notifier_call_chain and pass their own
role switch state as the argument. This chain will also be able to handle the
scenario of multiple modules switching roles on the same port since this can
create a priority and ordering among them for conflict resolution.

You are adding a new api that no one is actually using, so why would we
accept this at all?

And how can we actually review it without any real users?

Ack. The next version of this will be posted along with the usage
of these apis for ordering the role-switch.


thanks,

greg k-h