Re: [PATCH 11/14] scsi: ufs: host: Add support for parsing OPP

From: Manivannan Sadhasivam
Date: Thu Jul 13 2023 - 01:29:52 EST


On Thu, Jul 13, 2023 at 10:42:35AM +0530, Viresh Kumar wrote:
> On 13-07-23, 10:35, Manivannan Sadhasivam wrote:
> > We can settle with this custom callback for now. If there are drivers in the
> > future trying to do the same (skipping 0 freq) then we can generalize.
>
> Just for completeness, there isn't much to generalize here apart from
> changing the DT order of clocks. Isn't it ?
>

Even with changing the order, driver has to know the "interesting" clocks
beforehand. But that varies between platforms (this is a generic driver for
ufshc platforms).

And I do not know if clocks have any dependency between them, atleast not in
Qcom platforms. But not sure about others.

- Mani

> The change require for the OPP core makes sense, I will probably just
> push it anyway.
>
> --
> viresh

--
மணிவண்ணன் சதாசிவம்