Re: [PATCH] perf tools:remove unneeded variable from perf_event_attr__fprintf()

[Ian Rogers]

On Tue, Jun 13, 2023 at 11:25 PM <baomingtong001@xxxxxxxxxx> wrote:
>
> fix the following coccicheck warning:
>
> tools/perf/util/perf_event_attr_fprintf.c:97:5-8: Unneeded variable:
> "ret". Return "0".
>
> Signed-off-by: Mingtong Bao <baomingtong001@xxxxxxxxxx>

Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>   tools/perf/util/perf_event_attr_fprintf.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c
> b/tools/perf/util/perf_event_attr_fprintf.c
> index 7e5e7b30510d..4a8f625b80c7 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -94,7 +94,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
> perf_event_attr *attr,
>                    attr__fprintf_f attr__fprintf, void *priv)
>   {
>       char buf[BUF_SIZE];
> -    int ret = 0;
>
>       PRINT_ATTRf(type, p_unsigned);
>       PRINT_ATTRf(size, p_unsigned);
> @@ -155,5 +154,5 @@ int perf_event_attr__fprintf(FILE *fp, struct
> perf_event_attr *attr,
>       PRINT_ATTRf(aux_sample_size, p_unsigned);
>       PRINT_ATTRf(sig_data, p_unsigned);
>
> -    return ret;
> +    return 0;
>   }