Re: [PATCH 12/13] ASoC: SOF: Intel: Convert to PCI device IDs defines

From: Andy Shevchenko
Date: Wed Jul 12 2023 - 11:53:46 EST


On Wed, Jul 12, 2023 at 02:16:17PM +0200, Amadeusz Sławiński wrote:
> On 7/11/2023 4:16 PM, Andy Shevchenko wrote:
> > On Tue, Jul 11, 2023 at 02:57:25PM +0200, Amadeusz Sławiński wrote:

...

> > Oh, additional remark below.

> > > + { PCI_DEVICE_DATA(INTEL, HDA_APL, &bxt_desc) },
> > > + { PCI_DEVICE_DATA(INTEL, HDA_APL_T, &bxt_desc) },
> >
> > Have we ever had APL-T? What is that? I remember that we have had two or
> > three BXTs inside, and then products become for Broxton and Apollo Lake
> > SoC codenames. I never have heard about -T...
>
> I've talked a bit with Cezary and it seems that 0x1a98 is BXT-M (not -T) and
> it's an RVP, BXT-M B0 to be specific. From what we know no BXT is available
> on market. Perhaps we can just remove it?

If you go this way, it should be in a separate patch and it seems it has
already pre-cooked commit message (as per previous paragraph) :-)

--
With Best Regards,
Andy Shevchenko