RE: [EXT] Re: [net PATCH] octeontx2-af: Install TC filter rules in hardware based on priority

From: Suman Ghosh
Date: Wed Jul 12 2023 - 11:07:30 EST



>From: Suman Ghosh <sumang@xxxxxxxxxxx>
>Date: Mon, 3 Jul 2023 17:35:36 +0530
>
>> As of today, hardware does not support installing tc filter rules
>> based on priority. This patch fixes the issue and install the hardware
>> rules based on priority. The final hardware rules will not be
>> dependent on rule installation order, it will be strictly priority
>> based, same as software.
>>
>> Signed-off-by: Suman Ghosh <sumang@xxxxxxxxxxx>
>1. Targeted net (fixes), but no "Fixes:" tag.
>2. 350 locs of changes in a single commit. Is it so atomic, so that
> even can't be split logically?
> Esp. given that it's claimed as a fix, not a feature. Single 350-locs
> fixes do happen, but *very* rarely.
[Suman] After reconsideration, I think this should go as a feature as it is a new capability introduced.
I will push the patch in net-next. But yes, all the changes are atomic only.
>
>Thanks,
>Olek