Re: [v2, 1/2] mtd: spinand: toshiba: Fix ecc_get_status

From: Miquel Raynal
Date: Wed Jul 12 2023 - 10:09:35 EST


On Fri, 2023-06-23 at 15:33:36 UTC, Olivier Maignial wrote:
> Reading ECC status is failing.
>
> tx58cxgxsxraix_ecc_get_status() is using on-stack buffer
> for SPINAND_GET_FEATURE_OP() output. It is not suitable
> for DMA needs of spi-mem.
>
> Fix this by using the spi-mem operations dedicated buffer
> spinand->scratchbuf.
>
> See
> spinand->scratchbuf:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/mtd/spinand.h?h=v6.3#n418
> spi_mem_check_op():
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-mem.c?h=v6.3#n199
>
> Fixes: 10949af1681d ("mtd: spinand: Add initial support for Toshiba TC58CVG2S0H")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Olivier Maignial <olivier.maignial@xxxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel