Re: [PATCH v5 1/5] arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux

[Jayesh Choudhary]

On 12/07/23 16:51, Roger Quadros wrote:
> On 12/07/2023 08:44, Krzysztof Kozlowski wrote:
> > On 11/07/2023 17:31, Nishanth Menon wrote:
> > > On 12:01-20230711, Jayesh Choudhary wrote:
> > > > On 10/07/23 17:13, Krzysztof Kozlowski wrote:
> > > > > On 10/07/2023 12:17, Jayesh Choudhary wrote:
> > > > > > From: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> > > > > >
> > > > > > The system controller node manages the CTRL_MMR0 region.
> > > > > > Add serdes_ln_ctrl node which is used for controlling the SERDES lane mux.
> > > > > >
> > > > > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> > > > > > [j-choudhary@xxxxxx: Add reg property to fix dtc warning]
> > > > > > Signed-off-by: Jayesh Choudhary <j-choudhary@xxxxxx>
> > > > > > ---
> > > > > >    arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 23 ++++++++++++++++++++++
> > > > > >    1 file changed, 23 insertions(+)
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > > > > > index 2ea0adae6832..68cc2fa053e7 100644
> > > > > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > > > > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> > > > > > @@ -5,6 +5,9 @@
> > > > > >     * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/
> > > > > >     */
> > > > > > +#include <dt-bindings/mux/mux.h>
> > > > > > +#include <dt-bindings/mux/ti-serdes.h>
> > > > >
> > > > > Why? What do you use from that binding?
> > > >
> > > > Missed idle-state in the mux-controller node here for default values.
> > > > I will wait for more feedback and then re-spin the series.
> > >
> > > btw, I am wondering if ti-serdes.h should even exist in dt-bindings -
> > > are any of the macros used in the driver? or should this follow the
> > > pinctrl style macros that could happily reside in arch/arm64/boot/dts/ti
> > > ?
> >
> > I don't see any usage in drivers, which is a clear indication that it
> > might not be suitable for bindings. What are these values? Look like
> > some register values, which there is little sense in making a binding.
> >
> > Best regards,
> > Krzysztof
>
> You are right. They are constants not used in the driver directly.
> mmio-mux driver uses it to set the idle state of the mux via the
> 'idle-states' property.
>
> I agree with Nishanth that they should be moved to arch/arm64/boot/dts/ti

Then I will do the cleanup for all platforms and then post the dependent
series before spinning v6.

Thanks and Warm regards,
-Jayesh