Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

From: Henning Schild
Date: Wed Jul 12 2023 - 08:10:33 EST


Am Wed, 12 Jul 2023 12:52:52 +0100
schrieb Lee Jones <lee@xxxxxxxxxx>:

> On Thu, 06 Jul 2023, Henning Schild wrote:
>
> > This was found with giving the file to checkpatch.
> >
> > Signed-off-by: Henning Schild <henning.schild@xxxxxxxxxxx>
> > ---
> > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > bf258c32f83d..3d4877aa4e0c 100644 ---
> > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > +/* SPDX-License-Identifier: GPL-2.0 */
>
> What prompted this change?
>
> % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> 117
> % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> 2
>

./scripts/checkpatch.pl --no-tree --file
drivers/leds/simple/simatic-ipc-leds-gpio.h

it boils down to header versus c-file, not sure why headers prefer that
other style

Henning