Re: Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure

From: Abel Wu
Date: Wed Jul 12 2023 - 02:46:11 EST


Hi Jakub,

On 7/12/23 11:45 AM, Jakub Kicinski wrote:
On Tue, 11 Jul 2023 20:41:43 +0800 Abel Wu wrote:
Now there are two indicators of socket memory pressure sit inside
struct mem_cgroup, socket_pressure and tcpmem_pressure.

When in legacy mode aka. cgroupv1, the socket memory is charged
into a separate counter memcg->tcpmem rather than ->memory, so
the reclaim pressure of the memcg has nothing to do with socket's
pressure at all. While for default mode, the ->tcpmem is simply
not used.

So {socket,tcpmem}_pressure are only used in default/legacy mode
respectively. This patch fixes the pieces of code that make mixed
use of both.

Eric Dumazet is currently AFK, can we wait for him to return
(in about a week) before merging?

Sure, thanks for providing this information!

Best Regards,
Abel