Re: xfs WARNING on v6.5-rc1 kernel

From: Kees Cook
Date: Tue Jul 11 2023 - 17:37:33 EST


On Mon, Jul 10, 2023 at 10:02:43AM -0700, Darrick J. Wong wrote:
> On Mon, Jul 10, 2023 at 12:29:29PM -0400, Jeff Layton wrote:
> > I hit this this morning while running generic/013 (fsstress), with a
> > kernel based on v6.5-rc1. The main changes on top of this are timestamp
> > related, so I doubt they're a factor here.
> >
> > Is this some of the flexarray hardening?
>
> Yes.
>
> https://lore.kernel.org/linux-xfs/ZI+3QXDHiohgv%2FPb@xxxxxxxxxxxxxxxxxxx/
> https://lore.kernel.org/linux-xfs/bug-217522-201763-D34HpuP9xe@xxxxxxxxxxxxxxxxxxxxxxxxx%2F/
> https://lore.kernel.org/linux-xfs/Y9xiYmVLRIKdpJcC@work/

It looks like these just need struct tweaks to avoid using legacy array
definitions. It can be done without changes to the size of the structs,
etc.

I'll send a patch...

--
Kees Cook