Re: [PATCH] of: Preserve "of-display" device name for compatibility

From: Rob Herring
Date: Tue Jul 11 2023 - 13:05:45 EST


On Tue, Jul 11, 2023 at 9:46 AM Helge Deller <deller@xxxxxx> wrote:
>
> On 7/11/23 08:00, Thomas Zimmermann wrote:
> >
> >
> > Am 10.07.23 um 19:40 schrieb Rob Herring:
> >> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> >> as spotted by Frédéric Bonnard, the historical "of-display" device is
> >> gone: the updated logic creates "of-display.0" instead, then as many
> >> "of-display.N" as required.
> >>
> >> This means that offb no longer finds the expected device, which prevents
> >> the Debian Installer from setting up its interface, at least on ppc64el.
> >>
> >> Fix this by keeping "of-display" for the first device and "of-display.N"
> >> for subsequent devices.
> >>
> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
> >> Link: https://bugs.debian.org/1033058
> >> Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
> >> Cc: stable@xxxxxxxxxxxxxxx
> >> Cc: Cyril Brulebois <cyril@xxxxxxxxxxx>
> >> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> >> Cc: Helge Deller <deller@xxxxxx>
> >> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> >
> > Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
>
> Acked-by: Helge Deller <deller@xxxxxx>
>
> Who will pick up that patch?
> Shall I take it via fbdev git tree?

I'll take it. I've got other fixes queued up already.

Rob