Re: [PATCH v2 1/1] gpio: mmio: handle "ngpios" properly in bgpio_init()

[Andy Shevchenko]

On Tue, Jul 11, 2023 at 6:13 PM Asmaa Mnebhi <asmaa@xxxxxxxxxx> wrote:
>
> bgpio_init() uses "sz" argument to populate ngpio, which is not
> accurate. Instead, read the "ngpios" property from the DT and if it
> doesn't exist, use the "sz" argument. With this change, drivers no
> longer need to overwrite the ngpio variable after calling bgpio_init().
>
> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().
>
> Signed-off-by: Asmaa Mnebhi <asmaa@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> ---
> The following 2 patches were approved in March 2023 but didn't make
> it into the tree:
> [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()
> [PATCH v1] gpio: mmio: fix calculation of bgpio_bits
>
> They needed a rebase and were combined into a single patch since
> "gpio: mmio: fix calculation of bgpio_bits" fixes a bug in
> "gpio: mmio: handle "ngpios" properly in bgpio_init()"

And hence Linus' tag had been dropped.

LGTM now, thank you for pursuing this!
I hope Linus can review it again and Bart will be okay with the result
to be applied.

> v1->v2:
> - Added the tags
> - Updated the changelog

-- 
With Best Regards,
Andy Shevchenko