Re: [PATCH printk v2 3/5] printk: Consolidate console deferred printing
From: Sergey Senozhatsky
Date: Tue Jul 11 2023 - 11:18:05 EST
On (23/07/10 15:51), John Ogness wrote:
> Printing to consoles can be deferred for several reasons:
>
> - explicitly with printk_deferred()
> - printk() in NMI context
> - recursive printk() calls
>
> The current implementation is not consistent. For printk_deferred(),
> irq work is scheduled twice. For NMI und recursive, panic CPU
> suppression and caller delays are not properly enforced.
>
> Correct these inconsistencies by consolidating the deferred printing
> code so that vprintk_deferred() is the top-level function for
> deferred printing and vprintk_emit() will perform whichever irq_work
> queueing is appropriate.
>
> Also add kerneldoc for wake_up_klogd() and defer_console_output() to
> clarify their differences and appropriate usage.
>
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>
Looks good to me
Reviewed-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>